Compare moduleInfo in validating dependent type signatures in cache#432
Merged
NipunaRanasinghe merged 4 commits intoballerina-platform:1.2.xfrom Oct 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the validation logic for dependent type signatures in the diagram utility cache by incorporating module information checks. The main purpose is to ensure that dependent types are correctly matched not only by name but also by their module metadata (org name, module name, and version).
- Enhanced the
validateDependentTypesmethod to compare module information when matching dependent type symbols - Fixed the module ID retrieval to use the type descriptor's module instead of the type definition symbol's module
- Added a null check for
dependentTypeKeysbefore processing dependent types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| misc/diagram-util/src/main/java/org/ballerinalang/diagramutil/connector/models/connector/ReferenceType.java | Core logic changes: added module info comparison in dependent type validation and fixed module ID retrieval source |
| misc/diagram-util/src/test/resources/RefTypeTest/TestData/recordSample1.json | Removed empty dependentTypes field from test data |
| flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/data_mapper_model/config/query20.json | Removed unused SecondaryPhones record type definition from refs |
| flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/data_mapper_model/config/function_def6.json | Updated User type field from nested info record reference to direct firstName string field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...il/src/main/java/org/ballerinalang/diagramutil/connector/models/connector/ReferenceType.java
Show resolved
Hide resolved
NipunaRanasinghe
approved these changes
Oct 25, 2025
This was referenced Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Duplicate PR of #406 targeting patch 1.3.2
Fixes : wso2/product-ballerina-integrator#1493